Wasmtime GitHub notifications bot (Feb 23 2023 at 22:03): Wasmtime GitHub notifications bot (Feb 23 2023 at 22:03):elliottt opened PR #5870 from trevor/remove-module-emit-tests to main:
We have good coverage for these test cases in the per-isa precise-output tests, and after #5780 we can see both the VCode and disassembled output of those tests. These tests have historically been difficult to keep up to date, see the comment about dumping bytes out to a binary file and running objdump on each test, so removing them will help simplify the process of updating test expectations.
<!--Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Feb 23 2023 at 22:04):elliottt has marked PR #5870 as ready for review.
Wasmtime GitHub notifications bot (Feb 23 2023 at 22:55):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Feb 23 2023 at 22:55):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Feb 23 2023 at 22:55):cfallin created PR review comment:
Could we add a generic cold-blocks filetest? It looks like we have a few related to bugs (
atomic-cas-bug.clif,br_table.clif, and a few legalizer/verifier tests too) but none that try to generally exercise the feature like this test does.
Wasmtime GitHub notifications bot (Feb 23 2023 at 22:56):jameysharp submitted PR review.
Wasmtime GitHub notifications bot (Feb 23 2023 at 23:23):elliottt updated PR #5870 from trevor/remove-module-emit-tests to main.
Wasmtime GitHub notifications bot (Feb 24 2023 at 00:08):elliottt updated PR #5870 from trevor/remove-module-emit-tests to main.
Wasmtime GitHub notifications bot (Feb 24 2023 at 02:04):elliottt merged PR #5870.
Last updated: Oct 23 2024 at 20:03 UTC