Wasmtime GitHub notifications bot (Feb 23 2023 at 15:24): Wasmtime GitHub notifications bot (Feb 23 2023 at 15:24):uweigand opened PR #5864 from s390x-minmax-fix to main:
When expanding a min/max operation to a pair of icmp + select, do not attempt to expand the input value operands twice, as this might fail with memory operands.
Fixes https://github.com/bytecodealliance/wasmtime/issues/5859.
CC @afonso360 @cfallin
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Feb 23 2023 at 20:01):jameysharp submitted PR review.
Wasmtime GitHub notifications bot (Feb 23 2023 at 20:36):jameysharp merged PR #5864.
Last updated: Nov 22 2024 at 17:03 UTC