Stream: git-wasmtime

Topic: wasmtime / PR #5857 riscv64: Fix regalloc panic with `bor...

view this post on Zulip Wasmtime GitHub notifications bot (Feb 22 2023 at 21:26):

afonso360 edited PR #5857 from riscv64-fix-orn-regalloc to main:

:wave: Hey,

With zbb enabled we were optimizing bor+bnot into the orn instruction. We were accidentally also enabling this operation for floats without first moving the float to an integer register. This caused a regalloc error since we can't use those instructions directly on floats.

I've also tried to restrict the matches for some other rules that could probably suffer the same issue. Though the fuzzer hasn't complained about those yet.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 13 2023 at 18:10):

elliottt submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 13 2023 at 19:14):

afonso360 merged PR #5857.

Last updated: Nov 22 2024 at 16:03 UTC