Stream: git-wasmtime

Topic: wasmtime / PR #5856 cranelift: Add atomic_rmw to interpre...

Wasmtime GitHub notifications bot (Feb 22 2023 at 21:03):

jan-justin opened PR #5856 from cranelift_atomic_rmw to main:

This PR adds the atomic_rmw implementation to the interpreter in accordance with issue #5817 and ensures that the relevant filetest passes.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ x] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ x] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ x] This PR contains test cases, if meaningful.

• [x ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Feb 22 2023 at 21:21):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Feb 22 2023 at 21:21):

jameysharp created PR review comment:

Comparing this to the AtomicLoad and AtomicStore cases immediately afterward, I think this block can use the assign_or_memtrap helper. The similar block around the load above is harder since it doesn't necessarily return early.

Wasmtime GitHub notifications bot (Feb 22 2023 at 21:21):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Feb 23 2023 at 08:32):

jan-justin updated PR #5856 from cranelift_atomic_rmw to main.

Wasmtime GitHub notifications bot (Feb 23 2023 at 10:24):

afonso360 submitted PR review.

Wasmtime GitHub notifications bot (Feb 23 2023 at 11:02):

afonso360 merged PR #5856.

Last updated: Oct 23 2024 at 20:03 UTC