Wasmtime GitHub notifications bot (Feb 21 2023 at 20:09): Wasmtime GitHub notifications bot (Feb 21 2023 at 20:09):jameysharp opened PR #5848 from valid-opts-terms to main:
For instructions with no results (such as branches and stores) or instructions with multiple results (such as add with carry), we have assertions checking that an optimization rule doesn't try to match on or construct such instructions.
When we generate terms for matching or constructing instructions, the terms for these instructions are guaranteed to panic if they're ever used. So let's just not generate them.
In the future we may wish to generate terms with different types for these instructions, to make them usable in ISLE rules for optimization that fall outside our current egraph constraints.
Wasmtime GitHub notifications bot (Feb 21 2023 at 20:09):jameysharp requested cfallin for a review on PR #5848.
Wasmtime GitHub notifications bot (Feb 21 2023 at 21:00):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Feb 24 2023 at 01:45):jameysharp updated PR #5848 from valid-opts-terms to main.
Wasmtime GitHub notifications bot (Feb 24 2023 at 01:45):jameysharp has enabled auto merge for PR #5848.
Wasmtime GitHub notifications bot (Feb 24 2023 at 17:49):alexcrichton merged PR #5848.
Last updated: Dec 23 2024 at 12:05 UTC