Stream: git-wasmtime

Topic: wasmtime / PR #5845 fix issue 5714.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 21 2023 at 06:46):

yuyang-ok opened PR #5845 from issue5714 to main:

This fix https://github.com/bytecodealliance/wasmtime/issues/5714
I make a mistaken about the tmp register.
I think it is a int register, it is actual a float register.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 21 2023 at 06:51):

yuyang-ok edited PR #5845 from issue5714 to main:

This fix https://github.com/bytecodealliance/wasmtime/issues/5714
I make a mistaken about the tmp register.
I think it is an int register, it is actual a float register.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 21 2023 at 09:58):

yuyang-ok edited PR #5845 from issue5714 to main:

:clap: hey.

This fix https://github.com/bytecodealliance/wasmtime/issues/5714
I make a mistaken about the tmp register.
I think it is an int register, it is actual a float register.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 21 2023 at 22:28):

afonso360 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 21 2023 at 22:28):

afonso360 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 21 2023 at 22:28):

afonso360 created PR review comment:

Would you be able to add targets for the other architectures? Even though this issue didn't impact them, It's still a useful regression test!

view this post on Zulip Wasmtime GitHub notifications bot (Feb 22 2023 at 01:06):

yuyang-ok submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 22 2023 at 01:06):

yuyang-ok created PR review comment:

sure.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 22 2023 at 01:11):

yuyang-ok updated PR #5845 from issue5714 to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 23 2023 at 20:06):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 24 2023 at 01:04):

yuyang-ok updated PR #5845 from issue5714 to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 24 2023 at 01:39):

jameysharp has enabled auto merge for PR #5845.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 24 2023 at 01:40):

jameysharp has disabled auto merge for PR #5845.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 24 2023 at 01:40):

jameysharp has enabled auto merge for PR #5845.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 26 2023 at 17:10):

afonso360 merged PR #5845.

Last updated: Oct 23 2024 at 20:03 UTC