Stream: git-wasmtime

Topic: wasmtime / PR #5842 x64: Remove conditional `SseOpcode::u...

Wasmtime GitHub notifications bot (Feb 20 2023 at 16:49):

alexcrichton opened PR #5842 from remove-conditional-use-src1 to main:

This is a follow-up to comments in #5795 to remove some cruft in the x64 instruction model to ensure that the shape of an Inst reflects what's going to happen in regalloc and encoding. This accessor was used to handle round*, pextr*, and pshufb instructions. The round* ones had already moved to the appropriate XmmUnary* variant and pshufb was additionally moved over to that variant as well.

The pextr* instructions got a new Inst variant and additionally had their constructors slightly modified to no longer require the type as input. The encoding for these instructions now automatically handles the various type-related operands through a new SseOpcode::Pextrq operand to represent 64-bit movements.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Feb 21 2023 at 18:17):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Feb 21 2023 at 19:50):

cfallin merged PR #5842.

Last updated: Dec 23 2024 at 13:07 UTC