Wasmtime GitHub notifications bot (Feb 18 2023 at 00:45): Wasmtime GitHub notifications bot (Feb 18 2023 at 00:45):sunfishcode opened PR #5828 from sunfishcode/close-preopens to main:
Early on in WASI, we weren't sure whether we should allow preopens to be closed, so conservatively, we disallowed them. Among other things, this protected assumptions in wasi-libc that it can hold onto preopen file descriptors and rely on them always being open.
However now, I think it makes sense to relax this restriction. wasi-libc itself doesn't expose the preopen file descriptors, so users shouldn't ever be closing them naively, unless they have wild closes. And toolchains other than wasi-libc may want to close preopens as a way to drop priveleges once the main file handles are opened.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Feb 18 2023 at 00:46):sunfishcode requested pchickey for a review on PR #5828.
Wasmtime GitHub notifications bot (Feb 20 2023 at 00:27):pchickey submitted PR review.
Wasmtime GitHub notifications bot (Feb 24 2023 at 21:50):sunfishcode merged PR #5828.
Last updated: Dec 23 2024 at 12:05 UTC