Stream: git-wasmtime

Topic: wasmtime / PR #5826 Precompile compat key

Wasmtime GitHub notifications bot (Feb 17 2023 at 21:26):

lann opened PR #5826 from precompile-compat-key to main:

Draft for #5802 for naming / impl feedback prior to writing tests.

After writing the implementation I landed on precompile_compatibility_key to show the relationship with precompile_{module,component}, but can revert to the discussed cache_key if desired.

Wasmtime GitHub notifications bot (Feb 17 2023 at 21:27):

lann updated PR #5826 from precompile-compat-key to main.

Wasmtime GitHub notifications bot (Feb 17 2023 at 21:27):

lann submitted PR review.

Wasmtime GitHub notifications bot (Feb 17 2023 at 21:27):

lann created PR review comment:

Unclear to me if this is needed for this method.

Wasmtime GitHub notifications bot (Feb 17 2023 at 21:28):

lann submitted PR review.

Wasmtime GitHub notifications bot (Feb 17 2023 at 21:28):

lann created PR review comment:

I think a non-crypto hash is safe enough here. If an attacker can control enough of the build_compiler_info to force a collision you probably are already done for.

Wasmtime GitHub notifications bot (Feb 17 2023 at 21:28):

lann edited PR review comment.

Wasmtime GitHub notifications bot (Feb 17 2023 at 21:29):

lann edited PR review comment.

Wasmtime GitHub notifications bot (Feb 17 2023 at 21:30):

lann edited PR review comment.

Wasmtime GitHub notifications bot (Feb 17 2023 at 21:31):

lann edited PR review comment.

Last updated: Oct 23 2024 at 20:03 UTC