Wasmtime GitHub notifications bot (Feb 16 2023 at 20:57): Wasmtime GitHub notifications bot (Feb 16 2023 at 20:57):cfallin opened PR #5808 from disable-gvn-of-effectful-ops to main:
This is a short-term fix to the same bug that #5800 is addressing (#5796), but with less risk: it simply turns off GVN'ing of effectful but idempotent ops. Because we have an upcoming release, and this is a miscompile (albeit to do with trapping behavior), we would like to make the simplest possible fix that avoids the bug, and backport it. I will then rebase #5800 on top of a revert of this followed by the more complete fix.
This deletes the test that ensures that multiple dynamically-checked heap accesses are GVN'd, because removing this functionality in fact makes that no longer the case. It will come back with the revert and proper fix!
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Feb 16 2023 at 20:57):cfallin requested fitzgen for a review on PR #5808.
Wasmtime GitHub notifications bot (Feb 16 2023 at 20:57):cfallin requested elliottt for a review on PR #5808.
Wasmtime GitHub notifications bot (Feb 16 2023 at 20:57):cfallin requested jameysharp for a review on PR #5808.
Wasmtime GitHub notifications bot (Feb 16 2023 at 21:11):jameysharp submitted PR review.
Wasmtime GitHub notifications bot (Feb 16 2023 at 21:12):elliottt submitted PR review.
Wasmtime GitHub notifications bot (Feb 16 2023 at 21:13):cfallin has enabled auto merge for PR #5808.
Wasmtime GitHub notifications bot (Feb 16 2023 at 23:02):cfallin merged PR #5808.
Last updated: Oct 23 2024 at 20:03 UTC