Wasmtime GitHub notifications bot (Feb 16 2023 at 20:44): Wasmtime GitHub notifications bot (Feb 16 2023 at 20:44):saulecabrera opened PR #5807 from winch-x64-div to main:
This change is divided into two main commits
- 2e1ea496ea9a87341056ef63a375764db618c5f6, which performs the necessary refactoring to support the introduction of the division instructions.
- 2e1ea496ea9a87341056ef63a375764db618c5f6, introduces support for the instructions themselves.
I opted to include both commits in a single change to demonstrate the objective behind the refactor, but I'm happy to split them into two different changes if desired.
I added a detailed commit message to each to make reviewing easier.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Feb 16 2023 at 20:44):saulecabrera requested cfallin for a review on PR #5807.
Wasmtime GitHub notifications bot (Feb 16 2023 at 20:59):saulecabrera updated PR #5807 from winch-x64-div to main.
Wasmtime GitHub notifications bot (Feb 16 2023 at 21:34):saulecabrera updated PR #5807 from winch-x64-div to main.
Wasmtime GitHub notifications bot (Feb 17 2023 at 22:41):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Feb 17 2023 at 23:12):cfallin merged PR #5807.
Last updated: Dec 23 2024 at 12:05 UTC