Stream: git-wasmtime

Topic: wasmtime / PR #5803 Refactor collect_branches_and_targets...


view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2023 at 18:12):

elliottt opened PR #5803 from trevor/refactor-collect-branches-and-targets to main:

Basic blocks are terminated by at most one branch instruction now, so we can use that assumption in collect_branches_and_targets to return the last instruction we saw instead.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2023 at 18:19):

elliottt edited PR #5803 from trevor/refactor-collect-branches-and-targets to main:

Basic blocks are terminated by at most one branch instruction now, so we can use that assumption in collect_branches_and_targets to stop populating a mutable smallvec argument, and instead return the last instruction we saw.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2023 at 18:23):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2023 at 18:23):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2023 at 18:23):

jameysharp created PR review comment:

Reasoning through why this change is correct made my head hurt. However, from our conversations offline I guess you're aiming to clean up succ_indices after this, which I think should allow making this easier to understand. So I'm not going to think too hard about how to make this function more clear right now.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2023 at 18:23):

jameysharp created PR review comment:

These comments mentioning the first/second branch should be updated.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2023 at 18:50):

elliottt updated PR #5803 from trevor/refactor-collect-branches-and-targets to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2023 at 20:54):

elliottt updated PR #5803 from trevor/refactor-collect-branches-and-targets to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2023 at 21:09):

elliottt has enabled auto merge for PR #5803.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2023 at 23:36):

elliottt merged PR #5803.


Last updated: Dec 23 2024 at 12:05 UTC