Wasmtime GitHub notifications bot (Feb 16 2023 at 18:12): Wasmtime GitHub notifications bot (Feb 16 2023 at 18:12):elliottt opened PR #5803 from trevor/refactor-collect-branches-and-targets to main:
Basic blocks are terminated by at most one branch instruction now, so we can use that assumption in
collect_branches_and_targetsto return the last instruction we saw instead.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Feb 16 2023 at 18:19):elliottt edited PR #5803 from trevor/refactor-collect-branches-and-targets to main:
Basic blocks are terminated by at most one branch instruction now, so we can use that assumption in
collect_branches_and_targetsto stop populating a mutable smallvec argument, and instead return the last instruction we saw.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Feb 16 2023 at 18:23):jameysharp submitted PR review.
Wasmtime GitHub notifications bot (Feb 16 2023 at 18:23):jameysharp submitted PR review.
Wasmtime GitHub notifications bot (Feb 16 2023 at 18:23):jameysharp created PR review comment:
Reasoning through why this change is correct made my head hurt. However, from our conversations offline I guess you're aiming to clean up
succ_indicesafter this, which I think should allow making this easier to understand. So I'm not going to think too hard about how to make this function more clear right now.
Wasmtime GitHub notifications bot (Feb 16 2023 at 18:23):jameysharp created PR review comment:
These comments mentioning the first/second branch should be updated.
Wasmtime GitHub notifications bot (Feb 16 2023 at 18:50):elliottt updated PR #5803 from trevor/refactor-collect-branches-and-targets to main.
Wasmtime GitHub notifications bot (Feb 16 2023 at 20:54):elliottt updated PR #5803 from trevor/refactor-collect-branches-and-targets to main.
Wasmtime GitHub notifications bot (Feb 16 2023 at 21:09):elliottt has enabled auto merge for PR #5803.
Wasmtime GitHub notifications bot (Feb 16 2023 at 23:36):elliottt merged PR #5803.
Last updated: Nov 22 2024 at 17:03 UTC