Stream: git-wasmtime

Topic: wasmtime / PR #5798 Fix block label printing in precise-o...

Wasmtime GitHub notifications bot (Feb 16 2023 at 01:23):

elliottt opened PR #5798 from trevor/fix-block-printing to main:

As a follow-up to #5780, disassemble the regions identified by bb_starts, falling back on disassembling the whole buffer. This ensures that instructions like br_table that introduce a lot of constants don't throw off capstone for the remainder of the function.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Feb 16 2023 at 01:40):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Feb 16 2023 at 01:40):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Feb 16 2023 at 01:40):

jameysharp created PR review comment:

I guess this isn't quite the right types (usize vs whatever is in bb_starts) but I'd suggest something closer to this:

        block_starts.push(self.buffer.data().len());
        for (&start, &end) in block_starts.iter().zip(block_starts.iter().skip(1)) {

Wasmtime GitHub notifications bot (Feb 16 2023 at 01:40):

jameysharp created PR review comment:

This makes a little more sense to me:

        let mut block_starts = Vec::new();
        if self.bb_starts.first().copied() != Some(0) {
            block_starts.push(0);
        }
        block_starts.extend_from_slice(&self.bb_starts);

Wasmtime GitHub notifications bot (Feb 16 2023 at 01:44):

elliottt updated PR #5798 from trevor/fix-block-printing to main.

Wasmtime GitHub notifications bot (Feb 16 2023 at 01:48):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Feb 16 2023 at 01:48):

elliottt created PR review comment:

Great idea!

Wasmtime GitHub notifications bot (Feb 16 2023 at 01:49):

elliottt updated PR #5798 from trevor/fix-block-printing to main.

Wasmtime GitHub notifications bot (Feb 16 2023 at 01:51):

elliottt has enabled auto merge for PR #5798.

Wasmtime GitHub notifications bot (Feb 16 2023 at 02:35):

elliottt merged PR #5798.

Last updated: Nov 22 2024 at 17:03 UTC