Wasmtime GitHub notifications bot (Feb 16 2023 at 00:55): Wasmtime GitHub notifications bot (Feb 16 2023 at 00:55):alexcrichton opened PR #5797 from improve-x64-constant-vec-shifts to main:
I stumbled across this working on #5795 and figured this was a nice opportunity to improve the codegen here.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Feb 16 2023 at 00:57):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Feb 16 2023 at 00:57):alexcrichton created PR review comment:
I'll admit I don't know what's happening here. This I believe is the constant pool area and capstone is trying to decode it as instructions, but I don't know why after this change, which should generate a smaller constant pool, is generating more instructions here. I would hazard a guess that capstone automatically stoped beforehand for some reason and now it's keeping-on-going, but I'm not sure.
Wasmtime GitHub notifications bot (Feb 16 2023 at 01:42):jameysharp submitted PR review.
Wasmtime GitHub notifications bot (Feb 16 2023 at 01:42):jameysharp created PR review comment:
I think this is at least partially the same issue that @elliottt is tackling in #5798. We've discussed ways to entirely quit trying to disassemble constants since we think the machbuffer knows where they are, but one step at a time.
Wasmtime GitHub notifications bot (Feb 16 2023 at 15:33):alexcrichton updated PR #5797 from improve-x64-constant-vec-shifts to main.
Wasmtime GitHub notifications bot (Feb 16 2023 at 18:30):jameysharp submitted PR review.
Wasmtime GitHub notifications bot (Feb 16 2023 at 18:30):jameysharp created PR review comment:
Since #5798 is merged, can you try rebasing and see if the filetests look any better now?
Wasmtime GitHub notifications bot (Feb 16 2023 at 18:33):jameysharp submitted PR review.
Wasmtime GitHub notifications bot (Feb 16 2023 at 18:33):jameysharp created PR review comment:
Nevermind, I see you already did and it looks like it didn't help. I'm going to declare that this is harmless and move on with reviewing the rest of this PR.
Wasmtime GitHub notifications bot (Feb 16 2023 at 18:38):jameysharp submitted PR review.
Wasmtime GitHub notifications bot (Feb 16 2023 at 19:57):alexcrichton updated PR #5797 from improve-x64-constant-vec-shifts to main.
Wasmtime GitHub notifications bot (Feb 16 2023 at 19:57):alexcrichton has enabled auto merge for PR #5797.
Wasmtime GitHub notifications bot (Feb 16 2023 at 21:19):alexcrichton merged PR #5797.
Last updated: Nov 22 2024 at 17:03 UTC