Wasmtime GitHub notifications bot (Feb 15 2023 at 17:13): Wasmtime GitHub notifications bot (Feb 15 2023 at 17:13):elliottt opened PR #5789 from trevor/andn-formatting to main:
The formatting for the x64
AluRmRVexinstructions followed intel syntax, while we emit at&t syntax for everything else. This PR fixes the argument order in the pretty-printer, and updates the test outputs.
<!--Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Feb 15 2023 at 17:15):elliottt requested jameysharp for a review on PR #5789.
Wasmtime GitHub notifications bot (Feb 15 2023 at 17:28):elliottt edited PR #5789 from trevor/andn-formatting to main:
The formatting for the x64
AluRmRVexinstructions followed intel syntax, while we emit at&t syntax for everything else. This PR fixes the argument order in the pretty-printer, and updates the test outputs.This was identified in https://github.com/bytecodealliance/wasmtime/pull/5780#discussion_r1106570415
<!--Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Feb 15 2023 at 18:28):jameysharp submitted PR review.
Wasmtime GitHub notifications bot (Feb 15 2023 at 19:17):elliottt merged PR #5789.
Last updated: Dec 23 2024 at 12:05 UTC