Stream: git-wasmtime

Topic: wasmtime / PR #5777 Improve type imports into components

Wasmtime GitHub notifications bot (Feb 14 2023 at 15:50):

alexcrichton opened PR #5777 from fix-component-import-types to main:

This commit fixes a panic related to type imports where an import of a type didn't correctly declare the new type index on the Wasmtime side of things. Additionally this plumbs more support throughout Wasmtime to support type imports, namely that they do not need to be supplied through a Linker. This additionally implements a feature where empty instances, even transitively, do not need to be supplied by a Wasmtime embedder. This means that instances which only have types, for example, do not need to be supplied into a Linker since no runtime information for them is required anyway.

Closes #5775

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Feb 14 2023 at 18:00):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Feb 14 2023 at 18:02):

alexcrichton merged PR #5777.

Last updated: Dec 23 2024 at 12:05 UTC