Stream: git-wasmtime

Topic: wasmtime / PR #5763 Add (bnot (bxor x y)) lowerings for s...

Wasmtime GitHub notifications bot (Feb 10 2023 at 17:29):

alexcrichton opened PR #5763 from fuse-bnot-bxor to main:

I originally thought that s390x's original lowering in #5709, but as was rightfully pointed out (bnot (bxor x y)) is equivalent to (bxor x (bnot y)) so the special lowering for one should apply as a special lowering for the other. For the s390x and aarch64 backend that have already have a fused lowering of the bxor/bnot add a lowering additionally for the bnot/bxor combination.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Feb 10 2023 at 17:56):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Feb 10 2023 at 17:56):

elliottt created PR review comment:

vr128_ty matches $I128, should this be lower priority than the new rule on line 1058?

Wasmtime GitHub notifications bot (Feb 10 2023 at 20:41):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Feb 10 2023 at 20:41):

alexcrichton created PR review comment:

To confirm though, these are different architectures so I don't think there's overlap?

Wasmtime GitHub notifications bot (Feb 10 2023 at 20:49):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Feb 10 2023 at 20:49):

elliottt created PR review comment:

Whoops! Sorry about that :)

Wasmtime GitHub notifications bot (Feb 11 2023 at 00:18):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Feb 13 2023 at 15:10):

alexcrichton updated PR #5763 from fuse-bnot-bxor to main.

Wasmtime GitHub notifications bot (Feb 13 2023 at 15:10):

alexcrichton has enabled auto merge for PR #5763.

Wasmtime GitHub notifications bot (Feb 13 2023 at 15:41):

alexcrichton merged PR #5763.

Last updated: Nov 22 2024 at 17:03 UTC