Stream: git-wasmtime

Topic: wasmtime / PR #5763 Add (bnot (bxor x y)) lowerings for s...


view this post on Zulip Wasmtime GitHub notifications bot (Feb 10 2023 at 17:29):

alexcrichton opened PR #5763 from fuse-bnot-bxor to main:

I originally thought that s390x's original lowering in #5709, but as was rightfully pointed out (bnot (bxor x y)) is equivalent to (bxor x (bnot y)) so the special lowering for one should apply as a special lowering for the other. For the s390x and aarch64 backend that have already have a fused lowering of the bxor/bnot add a lowering additionally for the bnot/bxor combination.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Feb 10 2023 at 17:56):

elliottt submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 10 2023 at 17:56):

elliottt created PR review comment:

vr128_ty matches $I128, should this be lower priority than the new rule on line 1058?

view this post on Zulip Wasmtime GitHub notifications bot (Feb 10 2023 at 20:41):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 10 2023 at 20:41):

alexcrichton created PR review comment:

To confirm though, these are different architectures so I don't think there's overlap?

view this post on Zulip Wasmtime GitHub notifications bot (Feb 10 2023 at 20:49):

elliottt submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 10 2023 at 20:49):

elliottt created PR review comment:

Whoops! Sorry about that :)

view this post on Zulip Wasmtime GitHub notifications bot (Feb 11 2023 at 00:18):

elliottt submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 13 2023 at 15:10):

alexcrichton updated PR #5763 from fuse-bnot-bxor to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 13 2023 at 15:10):

alexcrichton has enabled auto merge for PR #5763.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 13 2023 at 15:41):

alexcrichton merged PR #5763.


Last updated: Dec 23 2024 at 12:05 UTC