Stream: git-wasmtime

Topic: wasmtime / PR #5755 Inline jump tables in parsed br_table...

Wasmtime GitHub notifications bot (Feb 09 2023 at 20:29):

elliottt opened PR #5755 from trevor/inline-jump-tables to main:

As jump tables are used by at most one br_table instruction, inline their definition in those instructions instead of requiring them to be declared as function-level metadata.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Feb 09 2023 at 21:25):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Feb 09 2023 at 21:25):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Feb 09 2023 at 21:25):

jameysharp created PR review comment:

Kinda weird that this renamed block2 to block3, but since neither of those blocks exist, this still tests the same thing it did before, so that's fine.

Wasmtime GitHub notifications bot (Feb 09 2023 at 21:28):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Feb 09 2023 at 21:28):

elliottt created PR review comment:

I did it to differentiate from the previous test, so that it was easier to tell on sight which one was causing errors :D

Wasmtime GitHub notifications bot (Feb 09 2023 at 21:30):

elliottt has marked PR #5755 as ready for review.

Wasmtime GitHub notifications bot (Feb 09 2023 at 21:31):

elliottt updated PR #5755 from trevor/inline-jump-tables to main.

Wasmtime GitHub notifications bot (Feb 09 2023 at 21:41):

elliottt updated PR #5755 from trevor/inline-jump-tables to main.

Wasmtime GitHub notifications bot (Feb 09 2023 at 21:42):

elliottt updated PR #5755 from trevor/inline-jump-tables to main.

Wasmtime GitHub notifications bot (Feb 09 2023 at 22:24):

elliottt merged PR #5755.

Last updated: Dec 23 2024 at 12:05 UTC