Stream: git-wasmtime

Topic: wasmtime / PR #5751 Add `JITBuilder::with_flags` constructor


view this post on Zulip Wasmtime GitHub notifications bot (Feb 09 2023 at 01:39):

Amanieu opened PR #5751 from jitbuilder_flags to main:

This allows custom flags to be set (e.g. opt-level) while still leaving most of of the boilerplate to select the native target to the JITBuilder.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Feb 09 2023 at 02:15):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 09 2023 at 02:15):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 09 2023 at 02:15):

jameysharp created PR review comment:

I didn't know this was legal syntax for constructing tuple-like structs and enum variants! I guess it's the prevailing style here but I'm not sure it should be. :sweat_smile:

view this post on Zulip Wasmtime GitHub notifications bot (Feb 09 2023 at 02:15):

jameysharp has enabled auto merge for PR #5751.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 09 2023 at 02:16):

Amanieu submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 09 2023 at 02:16):

Amanieu created PR review comment:

It's not how I would normally do it, but in this case I copied the other impl just above.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 09 2023 at 02:49):

jameysharp merged PR #5751.


Last updated: Dec 23 2024 at 13:07 UTC