Stream: git-wasmtime

Topic: wasmtime / PR #5751 Add `JITBuilder::with_flags` constructor

Wasmtime GitHub notifications bot (Feb 09 2023 at 01:39):

Amanieu opened PR #5751 from jitbuilder_flags to main:

This allows custom flags to be set (e.g. opt-level) while still leaving most of of the boilerplate to select the native target to the JITBuilder.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Feb 09 2023 at 02:15):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Feb 09 2023 at 02:15):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Feb 09 2023 at 02:15):

jameysharp created PR review comment:

I didn't know this was legal syntax for constructing tuple-like structs and enum variants! I guess it's the prevailing style here but I'm not sure it should be. :sweat_smile:

Wasmtime GitHub notifications bot (Feb 09 2023 at 02:15):

jameysharp has enabled auto merge for PR #5751.

Wasmtime GitHub notifications bot (Feb 09 2023 at 02:16):

Amanieu submitted PR review.

Wasmtime GitHub notifications bot (Feb 09 2023 at 02:16):

Amanieu created PR review comment:

It's not how I would normally do it, but in this case I copied the other impl just above.

Wasmtime GitHub notifications bot (Feb 09 2023 at 02:49):

jameysharp merged PR #5751.

Last updated: Nov 22 2024 at 16:03 UTC