Stream: git-wasmtime

Topic: wasmtime / PR #5745 Move jump tables to the DataFlowGraph


view this post on Zulip Wasmtime GitHub notifications bot (Feb 08 2023 at 01:14):

elliottt opened PR #5745 from trevor/jump-tables to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Feb 08 2023 at 01:17):

elliottt edited PR #5745 from trevor/jump-tables to main:

Move the storage for jump tables off of FunctionStencil and onto DataFlowGraph. This change is in service of #5731, making it easier to access the jump table data in the context of helpers like inst_values.

Moving the jump table data to DataFlowGraph is reasonable, as we are now assuming in more than one place that a jump table entry is used by at most one br_table instruction. As such, it's now more instruction side-data, rather than function side-data, and makes more sense to store in the DataFlowGraph.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Feb 08 2023 at 01:18):

elliottt edited PR #5745 from trevor/jump-tables to main:

Move the storage for jump tables off of FunctionStencil and onto DataFlowGraph. This change is in service of #5731, making it easier to access the jump table data in the context of helpers like inst_values.

Moving the jump table data to DataFlowGraph is reasonable, as we are now assuming in more than one place that a jump table entry is used by at most one br_table instruction. As such, it's now more instruction side-data, rather than function side-data, and makes more sense to store in the DataFlowGraph.

One open question I have is whether or not we should lock down the interface to DataFlowGraph::jump_tables in the same way that we have insts and blocks. There could be some value in restricting it, but as we didn't when it was public on FunctionStencil, I left it as a PrimaryMap.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Feb 08 2023 at 01:18):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 08 2023 at 01:18):

elliottt has marked PR #5745 as ready for review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 08 2023 at 05:21):

elliottt merged PR #5745.


Last updated: Dec 23 2024 at 12:05 UTC