Stream: git-wasmtime

Topic: wasmtime / PR #5737 winch: Add full support for integer `...

Wasmtime GitHub notifications bot (Feb 07 2023 at 20:55):

saulecabrera opened PR #5737 from winch-int-add-sub-ops to main:

This patch adds complete support for the sub and add WebAssembly instructions for x64, and complete support for the add WebAssembly instruction for aarch64 (which previously only supported i32).

This patch also refactors how the binary operations get constructed within the VisitOperator trait implementation. The refactor adds methods in the CodeGenContext to abstract all the common steps to emit binary operations, making this process less repetitive and less brittle (e.g. omitting to push the resulting value to the stack, or omitting to free registers after used).

This patch also improves test coverage and refactors the filetests directory to make it easier to add tests for other instructions.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Feb 07 2023 at 20:55):

saulecabrera requested cfallin for a review on PR #5737.

Wasmtime GitHub notifications bot (Feb 09 2023 at 01:01):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Feb 09 2023 at 01:01):

cfallin merged PR #5737.

Last updated: Dec 13 2025 at 19:03 UTC