Stream: git-wasmtime

Topic: wasmtime / PR #5736 Fix ABI of jitted function in craneli...


view this post on Zulip Wasmtime GitHub notifications bot (Feb 07 2023 at 20:26):

Raekye opened PR #5736 from main to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

Sorry if this is trivial! This issue was discussed on Zulip.

The jit-minimal example calls the jitted function using Rust's (not stable) ABI. The correct ABI should be extern "C".

I'm not sure who should review this.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 07 2023 at 20:26):

Raekye edited PR #5736 from main to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

Sorry if this is trivial! This issue was discussed on Zulip.

The jit-minimal example calls the jitted function using Rust's (not stable) ABI. The correct ABI should be extern "C".

I'm not sure who should review this, and I don't see a suggested list

view this post on Zulip Wasmtime GitHub notifications bot (Feb 07 2023 at 20:30):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 07 2023 at 20:30):

cfallin has enabled auto merge for PR #5736.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 07 2023 at 21:16):

cfallin merged PR #5736.


Last updated: Dec 23 2024 at 12:05 UTC