Stream: git-wasmtime

Topic: wasmtime / PR #5736 Fix ABI of jitted function in craneli...

Wasmtime GitHub notifications bot (Feb 07 2023 at 20:26):

Raekye opened PR #5736 from main to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Sorry if this is trivial! This issue was discussed on Zulip.

The jit-minimal example calls the jitted function using Rust's (not stable) ABI. The correct ABI should be extern "C".

I'm not sure who should review this.

Wasmtime GitHub notifications bot (Feb 07 2023 at 20:26):

Raekye edited PR #5736 from main to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Sorry if this is trivial! This issue was discussed on Zulip.

The jit-minimal example calls the jitted function using Rust's (not stable) ABI. The correct ABI should be extern "C".

I'm not sure who should review this, and I don't see a suggested list

Wasmtime GitHub notifications bot (Feb 07 2023 at 20:30):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Feb 07 2023 at 20:30):

cfallin has enabled auto merge for PR #5736.

Wasmtime GitHub notifications bot (Feb 07 2023 at 21:16):

cfallin merged PR #5736.

Last updated: Oct 23 2024 at 20:03 UTC