Stream: git-wasmtime

Topic: wasmtime / PR #5734 Refactor matches that used to consume...

Wasmtime GitHub notifications bot (Feb 07 2023 at 19:04):

elliottt opened PR #5734 from trevor/refactor-branch-matching to main:

Explicitly borrow the instruction data, and use a mutable borrow to avoid rematch

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Feb 07 2023 at 19:08):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Feb 07 2023 at 19:08):

elliottt created PR review comment:

This change is where #5730 really shines, as we can avoid matching the InstructionData twice.

Wasmtime GitHub notifications bot (Feb 07 2023 at 19:09):

elliottt has marked PR #5734 as ready for review.

Wasmtime GitHub notifications bot (Feb 07 2023 at 19:09):

elliottt requested fitzgen for a review on PR #5734.

Wasmtime GitHub notifications bot (Feb 07 2023 at 19:14):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Feb 07 2023 at 19:14):

elliottt created PR review comment:

Not that we couldn't have done that before, but removing BranchInfo ended up forcing the refactoring.

Wasmtime GitHub notifications bot (Feb 07 2023 at 19:44):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Feb 07 2023 at 21:29):

elliottt merged PR #5734.

Last updated: Dec 23 2024 at 12:05 UTC