Wasmtime GitHub notifications bot (Feb 07 2023 at 18:56): Wasmtime GitHub notifications bot (Feb 07 2023 at 18:56):elliottt opened PR #5733 from trevor/branch-assertions to main:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Feb 07 2023 at 18:58):elliottt edited PR #5733 from trevor/branch-assertions to main:
Following up from #5730, add assertions to ensure that new branch instructions don't slip through matches that used to use
analyze_branch.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Feb 07 2023 at 18:58):elliottt edited PR #5733 from trevor/branch-assertions to main:
Following up from #5730, add assertions to ensure that new branch instructions don't slip through matches that used to use
analyze_branch.cc @bjorn3
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Feb 07 2023 at 18:58):elliottt requested jameysharp for a review on PR #5733.
Wasmtime GitHub notifications bot (Feb 07 2023 at 20:46):jameysharp submitted PR review.
Wasmtime GitHub notifications bot (Feb 07 2023 at 21:37):elliottt updated PR #5733 from trevor/branch-assertions to main.
Wasmtime GitHub notifications bot (Feb 07 2023 at 22:51):elliottt merged PR #5733.
Last updated: Nov 22 2024 at 17:03 UTC