Stream: git-wasmtime

Topic: wasmtime / PR #5730 Remove analyze_branch and BranchInfo

Wasmtime GitHub notifications bot (Feb 07 2023 at 00:03):

elliottt opened PR #5730 from trevor/remove-branch-info to main:

We don't have overlap in behavior for branch instructions anymore, so we can remove analyze_branch and instead match on the InstructionData directly.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Feb 07 2023 at 00:05):

elliottt has marked PR #5730 as ready for review.

Wasmtime GitHub notifications bot (Feb 07 2023 at 00:05):

elliottt requested fitzgen for a review on PR #5730.

Wasmtime GitHub notifications bot (Feb 07 2023 at 00:05):

elliottt requested jameysharp for a review on PR #5730.

Wasmtime GitHub notifications bot (Feb 07 2023 at 00:11):

elliottt created PR review comment:

It's worth noting that once br_table uses BlockCall, we can replace the outer match with a mutable match, and remove this inner re-match.

Wasmtime GitHub notifications bot (Feb 07 2023 at 00:11):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Feb 07 2023 at 00:14):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Feb 07 2023 at 00:14):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Feb 07 2023 at 00:14):

jameysharp created PR review comment:

                // Redo the match from above, but this time capture mutable references

Wasmtime GitHub notifications bot (Feb 07 2023 at 00:18):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Feb 07 2023 at 00:18):

elliottt created PR review comment:

Yeah, that does read a bit better :sweat_smile:

Wasmtime GitHub notifications bot (Feb 07 2023 at 00:18):

elliottt updated PR #5730 from trevor/remove-branch-info to main.

Wasmtime GitHub notifications bot (Feb 07 2023 at 01:07):

elliottt merged PR #5730.

Last updated: Nov 22 2024 at 17:03 UTC