saulecabrera opened PR #5725 from fix-retrieving-function-signature
to main
:
This commit fixes an incorrect usage of
func_type_at
to retrieve a defined function signature and instead usesfunction_at
to retrieve the signature.Additionally it enhances
winch-tools
compile
andtest
commands to handle modules with multiple functions correctly.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
saulecabrera requested cfallin for a review on PR #5725.
saulecabrera edited PR #5725 from fix-retrieving-function-signature
to main
:
This commit fixes an incorrect usage of
func_type_at
to retrieve a defined function signature and instead usesfunction_at
to retrieve the signature. Without this change, compilation fails when trying to compile a module with multiple function definitions.Additionally it enhances
winch-tools
compile
andtest
commands to handle modules with multiple functions correctly.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
cfallin submitted PR review.
saulecabrera has enabled auto merge for PR #5725.
saulecabrera updated PR #5725 from fix-retrieving-function-signature
to main
.
saulecabrera merged PR #5725.
Last updated: Dec 23 2024 at 12:05 UTC