Stream: git-wasmtime

Topic: wasmtime / PR #5724 Algebraic opts: Reuse `iconst 0` from...

view this post on Zulip Wasmtime GitHub notifications bot (Feb 06 2023 at 21:07):

jameysharp opened PR #5724 from opts-reuse-lhs to main:

We don't need to spend time going through the GVN map to dedup a newly-constructed iconst 0 when we already matched that value on the left-hand side of these rules.

Also, mark these rules as subsuming any others since we can't do better than reducing an expression to a constant.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 06 2023 at 21:07):

jameysharp requested elliottt for a review on PR #5724.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 06 2023 at 22:10):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 06 2023 at 22:10):

alexcrichton created PR review comment:

Drive-by question not related to this actual PR, is this rule necessary given this rule that moves constants to the right?

view this post on Zulip Wasmtime GitHub notifications bot (Feb 06 2023 at 22:57):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 06 2023 at 22:57):

jameysharp created PR review comment:

Great question. I believe you're right that this rule is not necessary since we have that one. I'm not going to delete it right now though while we're still thinking through how best to express rules involving commutative operators. Chris, Nick, Trevor, and I had a long chat on the subject earlier today, but we don't have a complete plan yet.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 07 2023 at 23:19):

elliottt submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 07 2023 at 23:29):

jameysharp has enabled auto merge for PR #5724.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 07 2023 at 23:33):

jameysharp has disabled auto merge for PR #5724.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 07 2023 at 23:33):

jameysharp closed without merge PR #5724.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 07 2023 at 23:33):

jameysharp reopened PR #5724 from opts-reuse-lhs to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 07 2023 at 23:34):

jameysharp has enabled auto merge for PR #5724.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 08 2023 at 00:11):

jameysharp merged PR #5724.

Last updated: Nov 22 2024 at 16:03 UTC