Stream: git-wasmtime

Topic: wasmtime / PR #5723 Cranelift: Only build iconst for ints...

view this post on Zulip Wasmtime GitHub notifications bot (Feb 06 2023 at 20:57):

jameysharp opened PR #5723 from opts-iconst-types to main:

I audited the egraph "algebraic" optimization rules for any which construct an iconst on the right-hand side of the rule. In these cases we need to constrain the type passed to iconst to be both fits_in_64 and ty_int, because iconst is not defined on other types.

If there's some reason why icmp is already constrained to <=64 bits, I'd prefer to add comments explaining why instead of adding constraints to the rules.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 06 2023 at 20:57):

jameysharp requested fitzgen for a review on PR #5723.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 06 2023 at 20:57):

jameysharp requested cfallin for a review on PR #5723.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 06 2023 at 21:24):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 06 2023 at 22:10):

jameysharp merged PR #5723.

Last updated: Dec 23 2024 at 12:05 UTC