Stream: git-wasmtime

Topic: wasmtime / PR #5721 Keep reachable jump tables

Wasmtime GitHub notifications bot (Feb 06 2023 at 20:16):

elliottt opened PR #5721 from trevor/prune-jump-tables to main:

Instead of identifying unused branch tables by looking for unused blocks inside of them, track used branch tables while traversing reachable blocks. This introduces an extra allocation of an EntitySet to track the used jump tables, but as those are few and this function runs once per ir::Function, the allocation seems reasonable.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Feb 06 2023 at 20:23):

elliottt requested cfallin for a review on PR #5721.

Wasmtime GitHub notifications bot (Feb 06 2023 at 20:30):

elliottt requested jameysharp for a review on PR #5721.

Wasmtime GitHub notifications bot (Feb 06 2023 at 21:21):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Feb 06 2023 at 22:10):

elliottt merged PR #5721.

Last updated: Oct 23 2024 at 20:03 UTC