Stream: git-wasmtime

Topic: wasmtime / PR #5718 wasi: support opening with FdFlags::S...

Wasmtime GitHub notifications bot (Feb 06 2023 at 18:52):

pchickey opened PR #5718 from pch/open_options_sync_ext to main:

@sunfishcode just added OpenOptionsSyncExt to cap-fs-ext: https://docs.rs/cap-fs-ext/latest/cap_fs_ext/struct.OpenOptions.html#impl-OpenOptionsSyncExt-for-OpenOptions

This PR hooks up that trait to the relevant wasi-cap-std-sync path open method, and disables the workaround to ignore this misbehavior in our tests.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Feb 06 2023 at 18:52):

pchickey requested sunfishcode for a review on PR #5718.

Wasmtime GitHub notifications bot (Feb 06 2023 at 18:57):

pchickey updated PR #5718 from pch/open_options_sync_ext to main.

Wasmtime GitHub notifications bot (Feb 21 2023 at 19:11):

pchickey closed without merge PR #5718.

Last updated: Nov 22 2024 at 17:03 UTC