Stream: git-wasmtime

Topic: wasmtime / PR #5710 Cargo update cap-std family, and audi...

Wasmtime GitHub notifications bot (Feb 04 2023 at 02:42):

pchickey opened PR #5710 from pch/update_cap_std_openoptions to main:

I updated the whole cap-std family to their latest releases, so that I can (in an upcoming PR) add wasi-common support for opening with sync family of fdflags by way of https://github.com/bytecodealliance/cap-std/pull/292.

This cargo update ends us up with a dep on two versions of windows-sys. Everything in the cap-std family is on 0.45, except fd-lock using 0.42 to bump its dependency on windows-sys in order to resolve. I think that is acceptable for now, and I asked @sunfishcode to update fd-lock when he gets some time, but its not urgent.

I did the cargo vet diff audit this time, and it was pretty straightforward.

Wasmtime GitHub notifications bot (Feb 04 2023 at 02:42):

pchickey requested sunfishcode for a review on PR #5710.

Wasmtime GitHub notifications bot (Feb 05 2023 at 01:58):

pchickey updated PR #5710 from pch/update_cap_std_openoptions to main.

Wasmtime GitHub notifications bot (Feb 05 2023 at 19:45):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Feb 06 2023 at 13:53):

sunfishcode submitted PR review.

Wasmtime GitHub notifications bot (Feb 06 2023 at 13:53):

sunfishcode created PR review comment:

It's my understanding that cargo-vet audits are meant to be "append only", so we should add a new entry for safe-to-deploy rather than modifying the existing entry.

Wasmtime GitHub notifications bot (Feb 06 2023 at 13:53):

sunfishcode submitted PR review.

Wasmtime GitHub notifications bot (Feb 06 2023 at 17:30):

pchickey updated PR #5710 from pch/update_cap_std_openoptions to main.

Wasmtime GitHub notifications bot (Feb 06 2023 at 17:30):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Feb 06 2023 at 17:30):

pchickey created PR review comment:

Ok, I fixed this by making another entry.

Wasmtime GitHub notifications bot (Feb 06 2023 at 17:33):

pchickey edited PR #5710 from pch/update_cap_std_openoptions to main:

I updated the whole cap-std family to their latest releases, so that I can (in an upcoming PR) add wasi-common support for opening with sync family of fdflags by way of https://github.com/bytecodealliance/cap-std/pull/292.

I did the cargo vet diff audit this time, and it was pretty straightforward.

Wasmtime GitHub notifications bot (Feb 06 2023 at 18:16):

pchickey merged PR #5710.

Last updated: Nov 22 2024 at 16:03 UTC