Stream: git-wasmtime

Topic: wasmtime / PR #5703 winch: Add missing conversions betwee...

Wasmtime GitHub notifications bot (Feb 03 2023 at 20:26):

saulecabrera opened PR #5703 from winch-x64-asm-prep to main:

This commit adds some missing conversions between Winch's x64 Reg type and Cranelift's Gpr, WritableGpr and GprMemImm. This results in less boilerplate. This is also a bit of groundwork in the assembler to support the rest of the integer binary instructions.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Feb 03 2023 at 20:27):

saulecabrera requested cfallin for a review on PR #5703.

Wasmtime GitHub notifications bot (Feb 03 2023 at 20:27):

saulecabrera submitted PR review.

Wasmtime GitHub notifications bot (Feb 03 2023 at 20:27):

saulecabrera created PR review comment:

Changed this for consistency with the other binary operations (namely add).

Wasmtime GitHub notifications bot (Feb 03 2023 at 23:55):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Feb 03 2023 at 23:55):

cfallin merged PR #5703.

Last updated: Dec 23 2024 at 12:05 UTC