Stream: git-wasmtime

Topic: wasmtime / PR #5695 Cranelift: avoid debug-mode panics du...

Wasmtime GitHub notifications bot (Feb 02 2023 at 20:59):

fitzgen opened PR #5695 from issue-5690 to main:

Fixes #5690

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Feb 02 2023 at 20:59):

fitzgen requested jameysharp for a review on PR #5695.

Wasmtime GitHub notifications bot (Feb 02 2023 at 21:13):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Feb 02 2023 at 21:13):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Feb 02 2023 at 21:13):

cfallin created PR review comment:

It seems a little awkward here to do effectively two masks (down to 32 bits for y, then to log2(64) == 6 bits in wrapping_shl), one hidden and one explicit, and have an unwrap-path that may or may not be branch-folded away. It might be a little clearer to just write x << (y & 63), i.e. do the wrapping ourselves? To my eyes at least, it's much less stuff to parse and understand.

Wasmtime GitHub notifications bot (Feb 02 2023 at 21:13):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Feb 02 2023 at 21:15):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Feb 02 2023 at 21:15):

cfallin created PR review comment:

(It's also strange and unfortunate that wrapping_shl only takes a u32 amount on a u64 self; I wonder why...)

Wasmtime GitHub notifications bot (Feb 02 2023 at 21:16):

bjorn3 created PR review comment:

I believe it takes a u32 on all integer types.

Wasmtime GitHub notifications bot (Feb 02 2023 at 22:15):

fitzgen updated PR #5695 from issue-5690 to main.

Wasmtime GitHub notifications bot (Feb 02 2023 at 22:16):

fitzgen updated PR #5695 from issue-5690 to main.

Wasmtime GitHub notifications bot (Feb 02 2023 at 22:16):

fitzgen requested cfallin for a review on PR #5695.

Wasmtime GitHub notifications bot (Feb 02 2023 at 22:22):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Feb 02 2023 at 22:22):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Feb 02 2023 at 22:22):

cfallin created PR review comment:

Likewise here, self.ty_mask(ty)

Wasmtime GitHub notifications bot (Feb 02 2023 at 22:22):

cfallin created PR review comment:

We have a ty_mask function in the ISLE prelude that I think we could delegate to here instead?

Wasmtime GitHub notifications bot (Feb 02 2023 at 22:56):

fitzgen updated PR #5695 from issue-5690 to main.

Wasmtime GitHub notifications bot (Feb 02 2023 at 22:56):

fitzgen has enabled auto merge for PR #5695.

Wasmtime GitHub notifications bot (Feb 03 2023 at 00:12):

fitzgen merged PR #5695.

Last updated: Nov 22 2024 at 16:03 UTC