Wasmtime GitHub notifications bot (Feb 01 2023 at 20:01): Wasmtime GitHub notifications bot (Feb 01 2023 at 20:01):elliottt edited PR #5685 from trevor/generate-instance-pre-wrapper to main:
- Remove boolean parameters from instruction builder functions
- Fix names to not look like predicates
- More name changing
- Disable the wasi-nn test for now
- Generate an instance_pre wrapper in the component bindgen output
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Feb 01 2023 at 20:01):elliottt updated PR #5685 from trevor/generate-instance-pre-wrapper to main.
Wasmtime GitHub notifications bot (Feb 01 2023 at 20:02):elliottt edited PR #5685 from trevor/generate-instance-pre-wrapper to main:
Generate an
instance_premethod onSelfin the compnent bindgen macro, to simplify the use ofcomponent::InstancePre.
<!--Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Feb 01 2023 at 20:26):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Feb 01 2023 at 20:59):elliottt updated PR #5685 from trevor/generate-instance-pre-wrapper to main.
Wasmtime GitHub notifications bot (Feb 01 2023 at 21:14):elliottt updated PR #5685 from trevor/generate-instance-pre-wrapper to main.
Wasmtime GitHub notifications bot (Feb 01 2023 at 21:14):elliottt has marked PR #5685 as ready for review.
Wasmtime GitHub notifications bot (Feb 01 2023 at 21:39):elliottt updated PR #5685 from trevor/generate-instance-pre-wrapper to main.
Wasmtime GitHub notifications bot (Feb 01 2023 at 22:20):elliottt updated PR #5685 from trevor/generate-instance-pre-wrapper to main.
Wasmtime GitHub notifications bot (Feb 02 2023 at 00:03):elliottt updated PR #5685 from trevor/generate-instance-pre-wrapper to main.
Wasmtime GitHub notifications bot (Feb 02 2023 at 04:36):elliottt requested alexcrichton for a review on PR #5685.
Wasmtime GitHub notifications bot (Feb 02 2023 at 05:50):elliottt updated PR #5685 from trevor/generate-instance-pre-wrapper to main.
Wasmtime GitHub notifications bot (Feb 02 2023 at 15:26):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Feb 02 2023 at 15:26):alexcrichton merged PR #5685.
Last updated: Dec 23 2024 at 12:05 UTC