fitzgen opened PR #5684 from fix-or-and-rewrite
to main
:
This rewrite was introduced in #5676 and then reverted in #5682 due to a footgun where we accidentally weren't actually checking the
y == !z
precondition. This commit fixes the precondition check. It also fixes the arithmetic to be correctly masked to the value type's width.This reverts commit 268f6bfc1d383efe6793907c9d26209df2e96c94.
cc @avanhatt
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
fitzgen requested jameysharp for a review on PR #5684.
fitzgen requested cfallin for a review on PR #5684.
cfallin submitted PR review.
avanhatt submitted PR review.
avanhatt created PR review comment:
The verifier (which granted, is a prototype!) thinks this rule is now correct for BV8, BV16, BV32, and BV64!
fitzgen has enabled auto merge for PR #5684.
jameysharp submitted PR review.
fitzgen merged PR #5684.
Last updated: Dec 23 2024 at 12:05 UTC