Stream: git-wasmtime

Topic: wasmtime / PR #5673 Cranelift: Rewrite `(x>>k)<<k` into m...

Wasmtime GitHub notifications bot (Jan 31 2023 at 18:58):

fitzgen opened PR #5673 from shift-right-left-to-mask to main:

Thanks to Souper for pointing this one out! cc @regehr (let me know if you aren't interested in being cc'd on these!)

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jan 31 2023 at 18:58):

fitzgen requested cfallin for a review on PR #5673.

Wasmtime GitHub notifications bot (Jan 31 2023 at 19:06):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jan 31 2023 at 19:06):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jan 31 2023 at 19:06):

cfallin created PR review comment:

Should this be 0xFFFFFFFFFFFFFFFF instead (i.e., u64::MAX)? Otherwise, a comment why u32::MAX is sufficient?

(Likewise below)

Wasmtime GitHub notifications bot (Jan 31 2023 at 20:07):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jan 31 2023 at 20:07):

fitzgen created PR review comment:

D'oh!

Wasmtime GitHub notifications bot (Jan 31 2023 at 20:07):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jan 31 2023 at 20:07):

fitzgen created PR review comment:

FWIW: I originally had -1 but ISLE turns that into an i128 literal in the rust source code and then it fails to type check.

Wasmtime GitHub notifications bot (Jan 31 2023 at 20:21):

fitzgen updated PR #5673 from shift-right-left-to-mask to main.

Wasmtime GitHub notifications bot (Jan 31 2023 at 20:21):

fitzgen has enabled auto merge for PR #5673.

Wasmtime GitHub notifications bot (Jan 31 2023 at 20:24):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jan 31 2023 at 20:28):

fitzgen has disabled auto merge for PR #5673.

Wasmtime GitHub notifications bot (Jan 31 2023 at 20:38):

fitzgen updated PR #5673 from shift-right-left-to-mask to main.

Wasmtime GitHub notifications bot (Jan 31 2023 at 20:39):

fitzgen has enabled auto merge for PR #5673.

Wasmtime GitHub notifications bot (Jan 31 2023 at 21:11):

fitzgen merged PR #5673.

Wasmtime GitHub notifications bot (Jan 31 2023 at 21:15):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Jan 31 2023 at 21:15):

jameysharp created PR review comment:

Yup, that's my fault. See #5423 for why I think it's better than the alternative, and #5431 for Chris' proposal for improving this situation in the future.

Last updated: Dec 23 2024 at 12:05 UTC