Stream: git-wasmtime

Topic: wasmtime / PR #5668 Fix some warnings on nightly Rust

Wasmtime GitHub notifications bot (Jan 31 2023 at 15:18):

alexcrichton opened PR #5668 from fix-nightly-warning to main:

Cargo is warning about the usage of workspace dependencies where the workspace declaration does not mention default-features but the dependency mentions default-features, so this explicitly turns off default features for cranelift-codegen at the workspace level and removes the explicit default-features = false at the manifest levels.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jan 31 2023 at 15:33):

alexcrichton updated PR #5668 from fix-nightly-warning to main.

Wasmtime GitHub notifications bot (Jan 31 2023 at 15:41):

alexcrichton updated PR #5668 from fix-nightly-warning to main.

Wasmtime GitHub notifications bot (Jan 31 2023 at 16:06):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Jan 31 2023 at 18:20):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jan 31 2023 at 18:20):

fitzgen has enabled auto merge for PR #5668.

Wasmtime GitHub notifications bot (Jan 31 2023 at 20:15):

alexcrichton updated PR #5668 from fix-nightly-warning to main.

Wasmtime GitHub notifications bot (Jan 31 2023 at 20:55):

fitzgen merged PR #5668.

Last updated: Nov 22 2024 at 16:03 UTC