Stream: git-wasmtime

Topic: wasmtime / PR #5662 Cranelift: Fix `select` condition har...

Wasmtime GitHub notifications bot (Jan 30 2023 at 23:38):

fitzgen opened PR #5662 from compare-against-0 to main:

Souper requires an i1 condition value, we don't and will implicitly check against 0. We were truncating conditions in the harvester but should actually be inserting the comparison against 0.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jan 30 2023 at 23:38):

fitzgen requested elliottt for a review on PR #5662.

Wasmtime GitHub notifications bot (Jan 31 2023 at 03:14):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Jan 31 2023 at 05:25):

fitzgen merged PR #5662.

Last updated: Dec 23 2024 at 12:05 UTC