elliottt opened PR #5658 from main
to main
:
Remove the boolean parameters from the instruction builder functions, as they were only ever used with
true
. Additionally, change thereturn
andis_block
functions to implyis_terminator
.
<!--Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
elliottt has marked PR #5658 as ready for review.
bjorn3 submitted PR review.
bjorn3 created PR review comment:
If I were to see a function called is_terminator() without any context I would assume it returns a bool. Maybe name is make_terminator(), set_terminator() or terminator() instead?
elliottt submitted PR review.
elliottt created PR review comment:
Yeah, I think that's a good idea. We're already disabling the clippy lint for the name, so maybe now's the time to fix this.
elliottt updated PR #5658 from main
to main
.
jameysharp submitted PR review.
jameysharp submitted PR review.
jameysharp created PR review comment:
I think I like
terminator
best of these alternative names, but that's not so good for renamingis_return
. Other alternatives I'm thinking about areterminator_inst
orterminates_block
/returns
.
elliottt submitted PR review.
elliottt created PR review comment:
I picked
return_
, which I agree is not the nicest option. I likereturns
, and will switch to that. What about turning the others into actions as well? (terminates
,branches
,returns
)
jameysharp submitted PR review.
jameysharp created PR review comment:
Yeah, I like
branches
. I'm not certain aboutterminates
, so I suggestedterminates_block
. This is more bikeshedding than I intended to get into though and I'm happy enough with any of these options. :smile:
elliottt updated PR #5658 from main
to main
.
elliottt requested jameysharp for a review on PR #5658.
jameysharp submitted PR review.
bjorn3 submitted PR review.
elliottt merged PR #5658.
Last updated: Dec 23 2024 at 12:05 UTC