Stream: git-wasmtime

Topic: wasmtime / PR #5658 Remove boolean parameters from instru...

Wasmtime GitHub notifications bot (Jan 30 2023 at 22:00):

elliottt opened PR #5658 from main to main:

Remove the boolean parameters from the instruction builder functions, as they were only ever used with true. Additionally, change the return and is_block functions to imply is_terminator.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jan 30 2023 at 22:04):

elliottt has marked PR #5658 as ready for review.

Wasmtime GitHub notifications bot (Jan 30 2023 at 22:06):

bjorn3 submitted PR review.

Wasmtime GitHub notifications bot (Jan 30 2023 at 22:06):

bjorn3 created PR review comment:

If I were to see a function called is_terminator() without any context I would assume it returns a bool. Maybe name is make_terminator(), set_terminator() or terminator() instead?

Wasmtime GitHub notifications bot (Jan 30 2023 at 22:17):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Jan 30 2023 at 22:17):

elliottt created PR review comment:

Yeah, I think that's a good idea. We're already disabling the clippy lint for the name, so maybe now's the time to fix this.

Wasmtime GitHub notifications bot (Jan 30 2023 at 22:21):

elliottt updated PR #5658 from main to main.

Wasmtime GitHub notifications bot (Jan 30 2023 at 22:22):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Jan 30 2023 at 22:22):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Jan 30 2023 at 22:22):

jameysharp created PR review comment:

I think I like terminator best of these alternative names, but that's not so good for renaming is_return. Other alternatives I'm thinking about are terminator_inst or terminates_block/returns.

Wasmtime GitHub notifications bot (Jan 30 2023 at 22:40):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Jan 30 2023 at 22:40):

elliottt created PR review comment:

I picked return_, which I agree is not the nicest option. I like returns, and will switch to that. What about turning the others into actions as well? (terminates, branches, returns)

Wasmtime GitHub notifications bot (Jan 30 2023 at 22:42):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Jan 30 2023 at 22:42):

jameysharp created PR review comment:

Yeah, I like branches. I'm not certain about terminates, so I suggested terminates_block. This is more bikeshedding than I intended to get into though and I'm happy enough with any of these options. :smile:

Wasmtime GitHub notifications bot (Jan 30 2023 at 22:45):

elliottt updated PR #5658 from main to main.

Wasmtime GitHub notifications bot (Jan 30 2023 at 22:49):

elliottt requested jameysharp for a review on PR #5658.

Wasmtime GitHub notifications bot (Jan 30 2023 at 22:59):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Jan 30 2023 at 23:11):

bjorn3 submitted PR review.

Wasmtime GitHub notifications bot (Jan 31 2023 at 00:12):

elliottt merged PR #5658.

Last updated: Nov 22 2024 at 17:03 UTC