Wasmtime GitHub notifications bot (Jan 28 2023 at 01:01): Wasmtime GitHub notifications bot (Jan 28 2023 at 01:01):elliottt opened PR #5650 from trevor/fix-switch-underflow to main:
Fix an error introduced in #5644, where an unsigned subtraction from zero was possible with an empty Switch structure.
<!--Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jan 28 2023 at 01:01):elliottt requested jameysharp for a review on PR #5650.
Wasmtime GitHub notifications bot (Jan 28 2023 at 01:05):jameysharp submitted PR review.
Wasmtime GitHub notifications bot (Jan 28 2023 at 01:09):elliottt updated PR #5650 from trevor/fix-switch-underflow to main.
Wasmtime GitHub notifications bot (Jan 28 2023 at 01:12):elliottt edited PR #5650 from trevor/fix-switch-underflow to main:
Fix an error introduced in #5644, where an unsigned subtraction from zero was possible with an empty Switch structure. Additionally, missing the empty case caused us to not emit a branch to the default block. This PR fixes the issue by detecting the empty Switch case early, and emitting a jump. It also adds a test to ensure that this behavior stays consistent.
<!--Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jan 28 2023 at 01:13):elliottt updated PR #5650 from trevor/fix-switch-underflow to main.
Wasmtime GitHub notifications bot (Jan 28 2023 at 01:14):elliottt edited PR #5650 from trevor/fix-switch-underflow to main:
Fix an error introduced in #5644, where an unsigned subtraction from zero was possible with an empty Switch structure. Additionally, missing the empty case caused us to not emit a branch to the default block. This PR fixes the issue by detecting the empty Switch case early, and emitting a jump.
<!--Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jan 28 2023 at 01:14):elliottt has enabled auto merge for PR #5650.
Wasmtime GitHub notifications bot (Jan 28 2023 at 01:46):elliottt merged PR #5650.
Last updated: Nov 22 2024 at 16:03 UTC