Stream: git-wasmtime

Topic: wasmtime / PR #5649 Cranelift: Harvest each Souper LHS in...

Wasmtime GitHub notifications bot (Jan 27 2023 at 22:32):

fitzgen requested elliottt for a review on PR #5649.

Wasmtime GitHub notifications bot (Jan 27 2023 at 22:32):

fitzgen opened PR #5649 from lhs-per-file to main:

Souper only handles one input LHS at a time, so this makes it way easier to
script. Don't need to try and parse each LHS.

The audits are from when I was originally using blake3 to hash and dedupe each left-hand side. I gave up on auditing blake3 when I reached the large amounts of hand-written assembly, but maybe these other audits will be useful to us or someone else one day.

Wasmtime GitHub notifications bot (Jan 29 2023 at 00:09):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Jan 29 2023 at 00:09):

elliottt created PR review comment:

Keeping the set of hashes might skip some results due to collisions, right? Are the lhs strings too big to store in the HashSet instead?

Wasmtime GitHub notifications bot (Jan 29 2023 at 00:09):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Jan 30 2023 at 20:34):

fitzgen created PR review comment:

Yeah. I just didn't want to keep all the LHSs in memory and blake3 is pretty good an not-yet-known-to-be-broken so it seems safe. Also, I'm pretty sure I'm the only user of this tool :-p

Wasmtime GitHub notifications bot (Jan 30 2023 at 20:34):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jan 30 2023 at 20:58):

fitzgen requested elliottt for a review on PR #5649.

Wasmtime GitHub notifications bot (Jan 30 2023 at 21:15):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Jan 30 2023 at 21:24):

fitzgen merged PR #5649.

Last updated: Nov 22 2024 at 17:03 UTC