fitzgen requested elliottt for a review on PR #5649.
fitzgen opened PR #5649 from lhs-per-file
to main
:
Souper only handles one input LHS at a time, so this makes it way easier to
script. Don't need to try and parse each LHS.The audits are from when I was originally using
blake3
to hash and dedupe each left-hand side. I gave up on auditingblake3
when I reached the large amounts of hand-written assembly, but maybe these other audits will be useful to us or someone else one day.
elliottt submitted PR review.
elliottt created PR review comment:
Keeping the set of hashes might skip some results due to collisions, right? Are the
lhs
strings too big to store in the HashSet instead?
elliottt submitted PR review.
fitzgen created PR review comment:
Yeah. I just didn't want to keep all the LHSs in memory and blake3 is pretty good an not-yet-known-to-be-broken so it seems safe. Also, I'm pretty sure I'm the only user of this tool :-p
fitzgen submitted PR review.
fitzgen requested elliottt for a review on PR #5649.
elliottt submitted PR review.
fitzgen merged PR #5649.
Last updated: Dec 23 2024 at 12:05 UTC