fitzgen requested cfallin for a review on PR #5646.
fitzgen opened PR #5646 from shifts-are-simple
to main
:
No tests yet because the changes that build on top of this (strength reduction of multiplies by powers of two) is hitting ISLE codegen bugs. This should be safe enough to merge I think tho.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
fitzgen edited PR #5646 from shifts-are-simple
to main
:
No tests yet because the changes that build on top of this (strength reduction of multiplies by powers of two) is hitting ISLE codegen bugs. This should be safe enough to merge I think tho.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
cfallin submitted PR review.
cfallin merged PR #5646.
Last updated: Nov 22 2024 at 16:03 UTC