Stream: git-wasmtime

Topic: wasmtime / PR #5642 Delete old cranelift-preopt crate

view this post on Zulip Wasmtime GitHub notifications bot (Jan 26 2023 at 20:58):

jameysharp opened PR #5642 from no-preopt to main:

Most of these optimizations are in the egraph cprop.isle rules now, making a separate crate unnecessary.

Also I think the udiv optimizations here are straight-up wrong (doing signed instead of unsigned division, and panicking instead of preserving traps on division by zero) so I'm guessing this crate isn't seriously used anywhere.

At the least, bjorn3 confirms that cg_clif doesn't use this, and I've verified that Wasmtime doesn't either.

Closes #1090.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 26 2023 at 20:58):

jameysharp requested cfallin for a review on PR #5642.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 26 2023 at 21:00):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 26 2023 at 21:01):

jameysharp has enabled auto merge for PR #5642.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 26 2023 at 21:32):

jameysharp merged PR #5642.

Last updated: Nov 22 2024 at 16:03 UTC