elliottt opened PR #5638 from trevor/cranelift-wasm-brif
to main
:
Incrementally working towards removing
brz
andbrnz
completely.
<!--Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
elliottt requested jameysharp for a review on PR #5638.
elliottt edited PR #5638 from trevor/cranelift-wasm-brif
to main
:
Incrementally working towards removing
brz
andbrnz
completely.The meat of this change is that when we translate an
if
with noelse
branch, we're now fixing up a specific block of abrif
instruction, rather than the only destination of abrnz
instruction. Making this change also exposed thatchange_jump_destination
in cranelift-frontend was replacing all branch destinations. The fix there was to include the specific block that we're interested in rewriting, which also necessitated tracking that block value in cranelift-wasm as well.
<!--Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
elliottt edited PR #5638 from trevor/cranelift-wasm-brif
to main
:
Incrementally working towards removing
brz
andbrnz
completely.The meat of this change is that when we translate an
if
with noelse
branch, we're now fixing up a specific block of abrif
instruction, rather than the only destination of abrnz
instruction. Making this change also exposed thatchange_jump_destination
in cranelift-frontend was replacing all branch destinations. The fix there was to include the specific block that we're interested in rewriting, which also necessitated tracking that block value in cranelift-wasm.
<!--Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
fitzgen submitted PR review.
elliottt merged PR #5638.
Last updated: Dec 23 2024 at 13:07 UTC