Stream: git-wasmtime

Topic: wasmtime / PR #5638 Remove brz and brnz from cranelift-wasm

Wasmtime GitHub notifications bot (Jan 26 2023 at 01:42):

elliottt opened PR #5638 from trevor/cranelift-wasm-brif to main:

Incrementally working towards removing brz and brnz completely.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jan 26 2023 at 23:05):

elliottt requested jameysharp for a review on PR #5638.

Wasmtime GitHub notifications bot (Jan 27 2023 at 16:37):

elliottt edited PR #5638 from trevor/cranelift-wasm-brif to main:

Incrementally working towards removing brz and brnz completely.

The meat of this change is that when we translate an if with no else branch, we're now fixing up a specific block of a brif instruction, rather than the only destination of a brnz instruction. Making this change also exposed that change_jump_destination in cranelift-frontend was replacing all branch destinations. The fix there was to include the specific block that we're interested in rewriting, which also necessitated tracking that block value in cranelift-wasm as well.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jan 27 2023 at 16:37):

elliottt edited PR #5638 from trevor/cranelift-wasm-brif to main:

Incrementally working towards removing brz and brnz completely.

The meat of this change is that when we translate an if with no else branch, we're now fixing up a specific block of a brif instruction, rather than the only destination of a brnz instruction. Making this change also exposed that change_jump_destination in cranelift-frontend was replacing all branch destinations. The fix there was to include the specific block that we're interested in rewriting, which also necessitated tracking that block value in cranelift-wasm.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jan 27 2023 at 18:32):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jan 27 2023 at 18:34):

elliottt merged PR #5638.

Last updated: Dec 06 2025 at 06:05 UTC