Wasmtime GitHub notifications bot (Jan 26 2023 at 00:23): Wasmtime GitHub notifications bot (Jan 26 2023 at 00:23):elliottt opened PR #5636 from trevor/avoid-unordered-fcmp to main:
Improve the generated code for unordered floating point comparisons by negating the comparison and inveritng the branches. This allows us to pick the unordered versions, which generate significantly better code.
<!--Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jan 26 2023 at 00:45):jameysharp submitted PR review.
Wasmtime GitHub notifications bot (Jan 26 2023 at 01:28):elliottt has marked PR #5636 as ready for review.
Wasmtime GitHub notifications bot (Jan 26 2023 at 01:28):elliottt merged PR #5636.
Last updated: Dec 23 2024 at 12:05 UTC