Stream: git-wasmtime

Topic: wasmtime / PR #5633 wasmtime: default to blocking sockets

view this post on Zulip Wasmtime GitHub notifications bot (Jan 25 2023 at 16:25):

rvolosatovs opened PR #5633 from fix/blocking-sockets to main:

This commit is a follow-up on f81a663da7846ebf8a41282ef60b1eaf3c834e89, (https://github.com/bytecodealliance/wasmtime/pull/3729)
in which pre-opened socket support was added, but sockets opened by
wasmtime were made to default to non-blocking mode and pre-opened
sockets passed to wasmtime via listenfd were explicitly set to
non-blocking mode.

Avoid explicitly setting the mode and use OS default mode in the
former case or whichever mode was pre-configured in the latter.

Note, that Windows, POSIX and Berkeley sockets are blocking by default.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 25 2023 at 16:26):

haraldh submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 20 2023 at 12:32):

rvolosatovs requested wasmtime-core-reviewers for a review on PR #5633.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 20 2023 at 12:32):

rvolosatovs requested fitzgen for a review on PR #5633.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 20 2023 at 12:32):

rvolosatovs updated PR #5633.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 20 2023 at 18:54):

fitzgen requested pchickey for a review on PR #5633.

Last updated: Oct 23 2024 at 20:03 UTC