Stream: git-wasmtime

Topic: wasmtime / PR #5627 Produce an error at runtime rather th...

Wasmtime GitHub notifications bot (Jan 24 2023 at 18:37):

bjorn3 opened PR #5627 from cranelift-native-x86 to main:

…ed architectures in cranelift-native

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jan 24 2023 at 18:39):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jan 24 2023 at 18:39):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jan 24 2023 at 18:39):

cfallin created PR review comment:

I think the ISA lookup above will do the right thing here, without this x86-32-specific block at all?

Wasmtime GitHub notifications bot (Jan 24 2023 at 18:41):

bjorn3 submitted PR review.

Wasmtime GitHub notifications bot (Jan 24 2023 at 18:41):

bjorn3 created PR review comment:

Right

Wasmtime GitHub notifications bot (Jan 24 2023 at 18:41):

bjorn3 updated PR #5627 from cranelift-native-x86 to main.

Wasmtime GitHub notifications bot (Jan 24 2023 at 18:42):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jan 24 2023 at 18:42):

cfallin has enabled auto merge for PR #5627.

Wasmtime GitHub notifications bot (Jan 24 2023 at 19:17):

cfallin merged PR #5627.

Last updated: Dec 23 2024 at 13:07 UTC