Stream: git-wasmtime

Topic: wasmtime / PR #5622 Fix calculation of param/result types...

Wasmtime GitHub notifications bot (Jan 23 2023 at 17:09):

alexcrichton opened PR #5622 from fix-bindgen to main:

This commit fixes a bug in the bindgen! macro for components where previously the param and result properties weren't properly calculated depending on the structure of the type and which types were visited in which order. This is simplified to use a LiveTypes structure from the wit-parser crate and relies on that to do necessary recursion.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jan 23 2023 at 18:55):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Jan 23 2023 at 19:05):

alexcrichton has enabled auto merge for PR #5622.

Wasmtime GitHub notifications bot (Jan 23 2023 at 19:05):

alexcrichton merged PR #5622.

Last updated: Dec 23 2024 at 12:05 UTC