Stream: git-wasmtime

Topic: wasmtime / PR #5612 fix issue 5569.

Wasmtime GitHub notifications bot (Jan 21 2023 at 02:30):

yuyang-ok opened PR #5612 from issue5569 to main:

I think this fix issue #5569.
I didn't find which code cause Illegal instruction on riscv64 directly.
But I fix some code will cause some other problem.
Which will lead reg alloc been different and something else.
Right now We can pass the test.

Wasmtime GitHub notifications bot (Jan 21 2023 at 02:32):

yuyang-ok edited PR #5612 from issue5569 to main:

I think issue #5569 has been fixed.
I didn't find which code cause Illegal instruction on riscv64 directly.
But I fix some code will cause some other problem.
Which will lead reg alloc been different and something else.
Right now We can pass the test.

Wasmtime GitHub notifications bot (Jan 22 2023 at 02:30):

yuyang-ok updated PR #5612 from issue5569 to main.

Wasmtime GitHub notifications bot (Jan 22 2023 at 02:31):

yuyang-ok has marked PR #5612 as ready for review.

Wasmtime GitHub notifications bot (Jan 22 2023 at 21:17):

afonso360 created PR review comment:

Since we no longer emit the island, we should probably not update this.

Wasmtime GitHub notifications bot (Jan 22 2023 at 21:17):

afonso360 submitted PR review.

Wasmtime GitHub notifications bot (Jan 22 2023 at 22:55):

yuyang-ok updated PR #5612 from issue5569 to main.

Wasmtime GitHub notifications bot (Jan 22 2023 at 22:55):

yuyang-ok submitted PR review.

Wasmtime GitHub notifications bot (Jan 22 2023 at 22:55):

yuyang-ok created PR review comment:

sure.

Wasmtime GitHub notifications bot (Jan 30 2023 at 18:01):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jan 30 2023 at 18:01):

cfallin merged PR #5612.

Last updated: Oct 23 2024 at 20:03 UTC