Stream: git-wasmtime

Topic: wasmtime / PR #5611 fix rotl.i16 with i128 shift value.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 21 2023 at 06:34):

yuyang-ok edited PR #5611 from issue5523 to main:

This fix issue #5523.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 29 2023 at 16:15):

afonso360 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 29 2023 at 16:15):

afonso360 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 29 2023 at 16:15):

afonso360 created PR review comment:

Is this duplicate with the shamt_128 above? The const64 seems to already exist as well.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 30 2023 at 03:37):

yuyang-ok submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 30 2023 at 03:37):

yuyang-ok created PR review comment:

ok, thanks

view this post on Zulip Wasmtime GitHub notifications bot (Jan 30 2023 at 03:43):

yuyang-ok updated PR #5611 from issue5523 to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 30 2023 at 17:59):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 30 2023 at 17:59):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 30 2023 at 17:59):

cfallin created PR review comment:

This comment is outdated now, I think? This implementation does seem to support shifting by >= 64 bits, with the selects below.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 30 2023 at 17:59):

cfallin created PR review comment:

Just for good coverage while we're here, can we add the other targets (x86_64, aarch64, s390x) here too?

view this post on Zulip Wasmtime GitHub notifications bot (Jan 30 2023 at 23:09):

yuyang-ok submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 30 2023 at 23:09):

yuyang-ok created PR review comment:

Ok

view this post on Zulip Wasmtime GitHub notifications bot (Jan 30 2023 at 23:12):

yuyang-ok updated PR #5611 from issue5523 to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 31 2023 at 04:43):

yuyang-ok updated PR #5611 from issue5523 to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 01 2023 at 00:03):

yuyang-ok updated PR #5611 from issue5523 to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 01 2023 at 00:07):

yuyang-ok requested afonso360 for a review on PR #5611.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 01 2023 at 00:07):

yuyang-ok requested cfallin for a review on PR #5611.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 01 2023 at 02:56):

cfallin updated PR #5611 from issue5523 to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 01 2023 at 02:56):

cfallin has enabled auto merge for PR #5611.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 01 2023 at 03:44):

cfallin merged PR #5611.

Last updated: Nov 22 2024 at 16:03 UTC